Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies and fixes internal synchronization in the
kafka.Writer
type.There were a few issues:
Close
, racing with the check inWriteMessages
partitionWriter
wait group was done asynchronously after starting goroutines, racing with calls toWait
on these wait groupsI removed the sync group in
partitionWriter
and instead managed the count of inflight operations globally on a single wait group inWriter
; we only care about the writer'sClose
call to block until all inflight operations are done, there is no need to have a hierarchical synchronization scheme.Fixes #778